Delete Topic API #528
Merged
Delete Topic API #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2c7
force-pushed
the
delete-topics-api
branch
from
a5a1293 to
6c3c128
Compare
dasch
requested changes
Jan 22, 2018
|
|
||
| expect(kafka.partitions_for(topic)).to eq 3 | ||
| kafka.delete_topic(topic) | ||
| kafka.instance_variable_get(:@cluster).mark_as_stale! |
There was a problem hiding this comment.
This cluster should be marked as stale by Cluster#delete_topic.
|
|
||
| expect do | ||
| kafka.partitions_for(topic) | ||
| end.to raise_error(Kafka::LeaderNotAvailable) |
There was a problem hiding this comment.
Can you use Client#has_topic? here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The management API group already has CreateTopic API. This pull request is to implement DeleteTopicAPI. The implementation is based on official documentation https://kafka.apache.org/protocol#The_Messages_DeleteTopics. I choose API version 0 because, in the newest version, which is 1, the only difference is
throttle_time_msfield and it seems like we don't have a proper way to handle throttling. Therefore, the version 0 is safer.