Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for config entries in the topic creation API #540

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

tjwp
Copy link
Contributor

@tjwp tjwp commented Feb 18, 2018

I wanted to add this support so that I can create a topic that uses log compaction.

I did not add any validation of the config entry name and values here because the service will return an error if the name is not recognized or the value is invalid.

@dasch dasch merged commit bb61cf2 into zendesk:master Feb 19, 2018
@dasch
Copy link
Contributor

dasch commented Feb 19, 2018

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants