Disconnect after leaving the group #817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unnecessary reconnection after
Kafka::Consumer#stop
is called.@cluster.disconnect
closes the connections to all brokers including the coordinator in spite of the fact that@group.leave
requires a connection to the coordinator, so call@cluster.disconnect
after@group.leave
.You can confirm the behavior by executing the following script:
Before
After
As you can see above, the message "Opening connection to localhost:9092" disappeared in the log after the change.