Display richer status tooltips #2919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Sep 3, 2018
| status_counts << "#{failed.count} failed" if failed.any? | ||
| status_counts << "#{succeeded.count} succeeded" if succeeded.any? | ||
| status_counts << "#{errored.count} errored" if errored.any? | ||
| status_counts << "#{pending.count} pending" if pending.any? |
There was a problem hiding this comment.
how about something like that to avoid duplication here and also having to add another 4 copy-pasty methods that need to stay in sync with this code
[:failed?, :errored?, :pending?, :succeeded?].map do |status|
found = status.status.select(&status)
"#{found} #{status.to_s.sub('?', '')}" if found.any?
end.compactThere was a problem hiding this comment.
I'll take repetition over cleverness any day of the week...
There was a problem hiding this comment.
could use this to make it less clever/more repetitive but still dry, also solves all the 'missing test coverage' errors
[['failed, ':failed?], ['errored', :errored?], ['pending', :pending?], ['succeeded', :succeeded?]].map do |name, status|
found = status.status.select(&status)
"#{found} #{name}" if found.any?
end.compact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
/cc @zendesk/samson
Tasks
Risks