Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont error if secret visible key does not exist #4114

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

anthonywoo
Copy link
Contributor

Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.

Secrets can be created outside of Samson, and then managed through Samson. If a secret was created outside of Samson, it is possible for the secret not to have the visible key and users won't be able to access that secret in Samson

References

  • Jira link:

Risks

  • Low. There may be other issues with secrets created outside of Samson

Copy link
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best also add a test that fails without this fix

@anthonywoo anthonywoo marked this pull request as ready for review August 5, 2024 23:05
@anthonywoo
Copy link
Contributor Author

@grosser added a test. bundle_audit is failing, but that should be addressed in this PR

unless there are other concerns, my plan is to merge and deploy this tomorrow morning

@grosser grosser merged commit bf47fcd into master Aug 5, 2024
8 of 9 checks passed
@grosser grosser deleted the awoo/secret-visible branch August 5, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants