Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zcli-core as dependecy for apps #264

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove zcli-core as dependecy for apps #264

merged 1 commit into from
Sep 6, 2024

Conversation

anushkafka
Copy link
Contributor

@anushkafka anushkafka commented Sep 6, 2024 •
edited by github-actions bot
Loading

Description

e5062b8 Remove zcli-core as dependecy for apps

Detail

Checklist

  • 💂‍♂️ includes new unit and functional tests

@anushkafka anushkafka requested review from a team as code owners September 6, 2024 01:26
@yoshdog
Copy link
Member

yoshdog commented Sep 6, 2024

we are referencing @zendesk/zcli-core in here: https://github.com/zendesk/zcli/blob/master/packages/zcli-apps/src/commands/apps/update.ts#L11

@anushkafka
Copy link
Contributor Author

@yoshdog Technically it should still work because of this

zcli/packages/zcli/package.json

Line 20 in 12a08ce

"@zendesk/zcli-core": "^1.0.0-beta.49",

@anushkafka anushkafka merged commit ec2cc63 into master Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshdog yoshdog yoshdog approved these changes

@romeodemeteriojr romeodemeteriojr romeodemeteriojr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anushkafka @yoshdog @romeodemeteriojr