Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): pin sass version for zcli themes #272

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

BrunoBFerreira
Copy link
Contributor

@BrunoBFerreira BrunoBFerreira commented Sep 26, 2024

Description

Due to not having the sass version fixed, the previous upgrade changed the version, which caused sass related tests to fail. To prevent this from happening again, this PR introduces a fix to pin the sass version for zcli-themes.

a07ae4f Pin sass version for zcli themes

Detail

Checklist

  • 💂‍♂️ includes new unit and functional tests

@BrunoBFerreira BrunoBFerreira changed the title fix: pin sass version for zcli themes fix(tests): pin sass version for zcli themes Sep 26, 2024
@BrunoBFerreira BrunoBFerreira marked this pull request as ready for review September 26, 2024 10:52
@BrunoBFerreira BrunoBFerreira requested review from a team as code owners September 26, 2024 10:52
Copy link
Contributor

@anushkafka anushkafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍

@luis-almeida luis-almeida merged commit 03f2329 into master Sep 26, 2024
4 checks passed
@luis-almeida luis-almeida deleted the brunobferreira/fix-sass-version-tests branch September 26, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants