Skip to content

Adding count functionality to search #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding count functionality to search #528

wants to merge 1 commit into from

Conversation

@haakony
Copy link

@haakony haakony commented Feb 26, 2024

No description provided.

@haakony haakony mentioned this pull request Feb 28, 2024
Open
ecoologic
ecoologic reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤️

We require all code to be unit-tested, would you please be able to amend your PR?

Here's an example of a unit test.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ecoologic ecoologic ecoologic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haakony @ecoologic