Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added force_polling option into theme.rb #374

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

glook
Copy link
Contributor

@glook glook commented Jan 26, 2022

✌️

/cc @zendesk/vegemite

Description

Im using zendesk_app_tools via vm which mount volume via sshfs.

I see that you using listen gem to manage theme file changes.

Its readme says

some filesystems won't work without polling (VM/Vagrant Shared folders, NFS, Samba, sshfs, etc.)

Thats why I added --force-polling option into zat theme preview.

Tasks

  • Include comments/inline docs where appropriate
  • Write tests
  • Update changelog here

Risks

  • [HIGH | medium | low] Does it work on windows?
  • [HIGH | medium | low] Does it work in the different products (Support, Chat)?
  • [HIGH | medium | low] Are there any performance implications?
  • [HIGH | medium | low] Any security risks?
  • [HIGH | medium | low] What features does this touch?

@glook glook changed the title Added force_polling option tho theme.rb Added force_polling option into theme.rb Jan 26, 2022
@token-cjg
Copy link
Contributor

Thanks for this contribution, it will go out in the next release of ZAT.

@token-cjg token-cjg merged commit 02792e2 into zendesk:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants