Skip to content

fix(combobox): correct peer dependencies and label pixel shift #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(combobox): correct peer dependencies and label pixel shift #1562

merged 1 commit into from
Jun 28, 2023

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jun 28, 2023

Description

A few minor fixes, detailed below...

Detail

  • revert the underlying Label's vertical-align: center which isn't playing nice with the Combobox flex layout
  • bump the theming peer to 8.67.0, since we're taking advantage of focusStyles override parameters from that release
  • correct the styled-components peer to 5.1 as that is the transient props feature release

@jzempel jzempel requested a review from a team as a code owner June 28, 2023 12:48
geotrev
geotrev approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzempel jzempel merged commit 0409fa3 into main Jun 28, 2023
@jzempel jzempel deleted the patch-combobox branch June 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@geotrev geotrev geotrev approved these changes

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzempel @geotrev @Francois-Esquire @zendesk-garden