Skip to content

fix(combobox): prevent page scroll on input focus #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(combobox): prevent page scroll on input focus #1573

merged 1 commit into from
Jul 12, 2023

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 12, 2023

Description

Bump react-containers with the Combobox fix for preventing page scroll on focus.

Detail

zendeskgarden/react-containers#550

@jzempel jzempel requested a review from a team as a code owner July 12, 2023 18:57
geotrev
geotrev approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link

coveralls commented Jul 12, 2023

Coverage Status

coverage: 95.459%. remained the same when pulling 43059da on jzempel/combobox-scroll into 8c85c76 on main.

@jzempel jzempel merged commit 6553eae into main Jul 12, 2023
@jzempel jzempel deleted the jzempel/combobox-scroll branch July 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geotrev geotrev geotrev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzempel @coveralls @geotrev @zendesk-garden