Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 24, 2023

Description

Add programmatic and demo pointers to the new Combobox component.

@jzempel jzempel requested a review from a team as a code owner July 24, 2023 17:33
@coveralls
Copy link

Coverage Status

coverage: 95.481%. remained the same when pulling 3c097bd on jzempel/deprecate-dropdowns into 3124a28 on main.

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to test this out before merging, or will it be testable from website.git when the submodule is updated in a PR? Or does the website play a part at all here?

I see the updated label from the storybook README which looks good though. 👍

@jzempel
Copy link
Member Author

jzempel commented Jul 24, 2023

Is there any way to test this out before merging

@geotrev I checked imports in the related Story files to ensure folks will see the intended deprecation message.

Screenshot 2023-07-24 at 3 11 24 PM

@jzempel jzempel merged commit 323b441 into main Jul 24, 2023
@jzempel jzempel deleted the jzempel/deprecate-dropdowns branch July 24, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants