fix(combobox): enhance listbox expand/collapse on input mouse click #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Aug 18, 2023
| })<IStyledTagsButtonProps>` | ||
| display: inline-flex; | ||
| flex: 0 1 auto; /* [1] */ | ||
| align-items: center; |
There was a problem hiding this comment.
fixes a pixel off alignment issue observed between this button and value/input text
jzempel
commented
Aug 18, 2023
| } | ||
| return props.isEditable ? 'text' : 'pointer'; | ||
| return props.isEditable && !props.isAutocomplete ? 'text' : 'pointer'; |
There was a problem hiding this comment.
Since isAutocomplete now triggers expansion, we want the cursor to be a pointer
geotrev
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The underlying logic container bump to Downshift v8 applies updated input click-to-expand functionality that falls more in line with the APG specification. By adopting this update, Garden's new
Comboboxnow has click-to-expand behavior parity with the deprecated Autocomplete component.Detail
zendeskgarden/react-containers#565
Checklist
yarn start)?bedrock)