Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdowns.next): active listbox option and menu item styling #1655

Merged
merged 17 commits into from
Nov 20, 2023
Merged

fix(dropdowns.next): active listbox option and menu item styling #1655

merged 17 commits into from
Nov 20, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Nov 13, 2023 •
edited
Loading

Description

Use box-shadow styling to add a start-side activation border to:

  • Combobox listbox Option
  • Menu Item

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@zendesk-garden zendesk-garden requested a deployment to staging November 13, 2023 22:18 Abandoned
@jzempel
Copy link
Member Author

jzempel commented Nov 13, 2023

@lucijanblagonic here's the storybook deployment: https://6552a529dd190d39c02ca03e--jzempel.netlify.app/?path=/story/packages-dropdowns-next-combobox--uncontrolled

@zendesk-garden zendesk-garden requested a deployment to staging November 14, 2023 17:36 Abandoned
@jzempel jzempel marked this pull request as ready for review November 16, 2023 18:35
@jzempel jzempel requested a review from a team as a code owner November 16, 2023 18:35
smritimadan
smritimadan approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@smritimadan smritimadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@zendesk-garden zendesk-garden requested a deployment to staging November 16, 2023 18:55 Abandoned
@zendesk-garden zendesk-garden requested a deployment to staging November 17, 2023 22:57 Abandoned
@jzempel jzempel merged commit 2d4847f into main Nov 20, 2023
1 check passed
@jzempel jzempel deleted the jzempel/dropdown-focus branch November 20, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smritimadan smritimadan smritimadan approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzempel @smritimadan @zendesk-garden