Skip to content

fix(deps): update non-major package dependencies #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix(deps): update non-major package dependencies #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f7448
fix(deps): update non-major package dependencies
renovate[bot] Feb 2, 2024
753cde0
Update useAccordion API
jzempel Feb 2, 2024
6623346
Update to not ignore dropdowns.next
jzempel Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": ["config:base"],
"rebaseStalePrs": true,
"ignorePaths": ["**/node_modules/**", "packages/dropdowns"],
"ignorePaths": ["**/node_modules/**", "packages/dropdowns/**"],
"schedule": ["on Monday every 9 weeks of the year starting on the 5th week"],
"labels": ["PR: Internal :seedling:"],
"postUpdateOptions": ["npmDedupe"],
Expand Down
51 changes: 5 additions & 46 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/chrome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"sideEffects": false,
"types": "dist/typings/index.d.ts",
"dependencies": {
"@zendeskgarden/container-accordion": "^2.0.0",
"@zendeskgarden/container-accordion": "^3.0.4",
"@zendeskgarden/container-utilities": "^2.0.0",
"dom-helpers": "^5.2.1",
"polished": "^4.0.0",
Expand Down
35 changes: 19 additions & 16 deletions packages/chrome/src/elements/subnav/CollapsibleSubNavItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* found at http://www.apache.org/licenses/LICENSE-2.0.
*/

import React, { useEffect, useRef, useState } from 'react';
import React, { ButtonHTMLAttributes, HTMLAttributes, createRef, useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { useAccordion } from '@zendeskgarden/container-accordion';
import { getControlledValue } from '@zendeskgarden/container-utilities';
Expand All @@ -24,12 +24,14 @@ import { useChromeContext } from '../../utils/useChromeContext';
export const CollapsibleSubNavItem = React.forwardRef<HTMLDivElement, ICollapsibleSubNavItemProps>(
({ header, children, isExpanded: controlledExpanded, onChange, ...other }, ref) => {
const { isDark, isLight } = useChromeContext();
const panelRef = useRef<HTMLDivElement>();
const panelRef = createRef<HTMLDivElement>();
const [internalExpanded, setInternalExpanded] = useState(controlledExpanded);
const expanded = getControlledValue(controlledExpanded, internalExpanded);
const expandedSections = expanded ? [0] : [];
const value = 0;
const expandedSections = expanded ? [value] : [];

const { getHeaderProps, getTriggerProps, getPanelProps } = useAccordion({
sections: [value],
expandedSections,
onChange: () => {
const isExpanded = expandedSections.length === 0;
Expand All @@ -46,21 +48,22 @@ export const CollapsibleSubNavItem = React.forwardRef<HTMLDivElement, ICollapsib
if (expanded && panelRef.current) {
panelRef.current.style.maxHeight = `${panelRef.current.scrollHeight}px`;
}
}, [expanded, children]);
}, [expanded, children, panelRef]);

return (
<div ref={ref}>
<div {...getHeaderProps({ ariaLevel: 2 })}>
<div {...getHeaderProps({ 'aria-level': 2 })}>
<StyledSubNavItemHeader
isDark={isDark}
isLight={isLight}
{...getTriggerProps({
isExpanded: expanded,
index: 0,
isExpanded={expanded}
{...(getTriggerProps({
...other,
role: null,
tabIndex: null,
...other
})}
tabIndex: null as any,
value
}) as ButtonHTMLAttributes<HTMLButtonElement>)}
type="button"
>
<>
{header}
Expand All @@ -71,11 +74,11 @@ export const CollapsibleSubNavItem = React.forwardRef<HTMLDivElement, ICollapsib
</StyledSubNavItemHeader>
</div>
<StyledSubNavPanel
{...getPanelProps({
index: 0,
isHidden: !expanded,
ref: panelRef
})}
isHidden={!expanded}
{...(getPanelProps({
ref: panelRef,
value
}) as HTMLAttributes<HTMLDivElement>)}
>
{children}
</StyledSubNavPanel>
Expand Down