fix(menu): correct RTL menu placement and arrow position #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smritimadan
approved these changes
Feb 15, 2024
geotrev
pushed a commit
that referenced
this pull request
Feb 15, 2024
Fixes RTL placement for: - `top-start` - `top-end` - `bottom-start` - `bottom-end`
7 tasks
geotrev
added a commit
that referenced
this pull request
Feb 16, 2024
changes added: - fix(menu): correct RTL menu placement and arrow position (#1708) Co-authored-by: Jonathan Zempel <jzempel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Floating UI uses logical placement. As a result, there is less
placementprop mapping to do then with Popper. This PR addresses a handful of placement combinations that were incorrect with RTL layouts.Detail
Before with
placement="top-start"After with
placement="top-start"Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with Bedrock CSS (?bedrock)includes new unit tests. Maintain existing coverage (always >= 96%)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge