Skip to content

Conversation

@geotrev
Copy link
Contributor

@geotrev geotrev commented Feb 21, 2024

Description

Renames DrawerModal to Drawer to match website language.

Detail

No discrete component code was changed.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

coveralls commented Feb 21, 2024

Coverage Status

coverage: 96.106%. remained the same
when pulling 77ba6d2 on george/drawer-rename
into 28b5fa6 on next.

@geotrev geotrev marked this pull request as ready for review February 21, 2024 19:31
@geotrev geotrev requested a review from a team as a code owner February 21, 2024 19:31
<TooltipModal.Close aria-label="Close" />
</TooltipModal>
</ThemeProvider>;
```
Copy link
Contributor Author

@geotrev geotrev Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed worthwhile including these.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add migration.md details

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a potential [nit] modification. Feel free to merge when ready.

@geotrev geotrev merged commit d43da03 into next Feb 22, 2024
@geotrev geotrev deleted the george/drawer-rename branch February 22, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants