Skip to content

Conversation

@geotrev
Copy link
Contributor

@geotrev geotrev commented Mar 4, 2024

Description

Components affected:

  • DatePicker
  • Menu
  • TooltipModal
  • Tooltip

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure a cherry pick is our best bet for next. All of the new Floating UI implementations need this fix on next.

@geotrev geotrev changed the title fix(dropdowns): cherry-picks menu RTL fix fix: adds RTL fix for floating ui implementations Mar 4, 2024
@geotrev geotrev changed the title fix: adds RTL fix for floating ui implementations fix: adds rtl fix for floating ui implementations Mar 4, 2024
@geotrev geotrev merged commit 39e7e64 into next Mar 5, 2024
@geotrev geotrev deleted the george/menu-rtl-cp branch March 5, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants