Skip to content

Conversation

@geotrev
Copy link
Contributor

@geotrev geotrev commented Mar 4, 2024

Description

  • Creates sub-component mapping for react-tabs and react-tooltips
  • Updates demo
  • Deprecates legacy stand-alone exports

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

coveralls commented Mar 4, 2024

Coverage Status

coverage: 96.023% (+0.004%) from 96.019%
when pulling cc2fa66 on george/tooltips-tabs-mapping
into 0061baa on next.

@geotrev geotrev marked this pull request as draft March 5, 2024 15:39
@geotrev geotrev force-pushed the george/tooltips-tabs-mapping branch from 98f7936 to d8dd819 Compare March 5, 2024 16:40
@geotrev geotrev changed the base branch from main to next March 5, 2024 16:40
@geotrev geotrev marked this pull request as ready for review March 5, 2024 16:50
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API ergonomics are feeling niiiice.

Co-authored-by: Jonathan Zempel <jzempel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants