Skip to content

fix(dropdowns): controlled Combobox input value regression #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(dropdowns): controlled Combobox input value regression #1735

merged 1 commit into from
Mar 5, 2024

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Mar 5, 2024 •
edited
Loading

Description

Controlled inputValue behavior for Combobox regressed in v8.74.1 due to a "cursor jump" fix in #1705. This PR updates the underlying container with a fix that keeps inputValue sync'd with underlying Downshift.

Detail

zendeskgarden/react-containers#628

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from a team as a code owner March 5, 2024 20:43
@coveralls
Copy link

coveralls commented Mar 5, 2024

Coverage Status

coverage: 96.194%. remained the same
when pulling 166c0d8 on jzempel/fix-controlled-combobox
into 3e3be91 on main.

@jzempel jzempel merged commit fd48963 into main Mar 5, 2024
@jzempel jzempel deleted the jzempel/fix-controlled-combobox branch March 5, 2024 21:12
jzempel added a commit that referenced this pull request Mar 7, 2024
@jzempel
fix(dropdowns): controlled Combobox input value regression (#1735)
82ee0f9
jzempel added a commit that referenced this pull request Mar 7, 2024
@jzempel
chore(next): updates from main (#1738)
a23c1a6 
* chore(deps-dev): bump ip from 2.0.0 to 2.0.1 (#1713)
* chore(changelog): add v8.74.3 [skip ci]
* fix(dropdowns): controlled `Combobox` input value regression (#1735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geotrev geotrev geotrev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzempel @coveralls @geotrev @zendesk-garden