feat(chrome): adds sub-component mapping #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
changed the title
geotrev
commented
Mar 5, 2024
docs/migration.md
Outdated
|
|
||
| - Removed `PRODUCT` type export. Use `IHeaderItemProps['product']` instead. | ||
| - Some subcomponent exports have been deprecated and will be removed in a future major version. | ||
| Update to subcomponent properties. |
There was a problem hiding this comment.
Wondering if we should document the specific mapping here, since it's a bit more nebulous with the number of components in the package.
There was a problem hiding this comment.
Yeah, I'd recommend copying the mapping from your PR description to a bulleted sublist here.
jzempel
requested changes
Mar 6, 2024
There was a problem hiding this comment.
collapsibleSubNavItemstory should appear asSubNav.CollapsibleItem- the
ICollapsibleSubNavItemPropstype should be renamed (breaking change) toISubNavCollapsibleItemPropsfor consistency - Something appears to be wrong with the deployment: https://65e794c2314708716dd557ee--zendeskgarden-react-components.netlify.app/?path=/docs/packages-chrome-chrome--docs
docs/migration.md
Outdated
|
|
||
| - Removed `PRODUCT` type export. Use `IHeaderItemProps['product']` instead. | ||
| - Some subcomponent exports have been deprecated and will be removed in a future major version. | ||
| Update to subcomponent properties. |
There was a problem hiding this comment.
Yeah, I'd recommend copying the mapping from your PR description to a bulleted sublist here.
jzempel
approved these changes
Mar 7, 2024
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
react-chromeFooterItem->Footer.ItemHeaderItem->Header.ItemHeaderItemIcon->Header.ItemIconHeaderItemText->Header.ItemTextHeaderItemWrapper->Header.ItemWrapperNavItem->Nav.ItemNavItemIcon->Nav.ItemIconNavItemText->Nav.ItemTextCollapsibleSubNavItem->SubNav.CollapsibleItemSubNavItem->SubNav.ItemSubNavItemText->SubNav.ItemTextChecklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)💂♂️ includes new unit tests. Maintain existing coverage (always >= 96%)♿ tested for WCAG 2.1 AA accessibility compliance📝 tested in Chrome, Firefox, Safari, and Edge