feat(theming)!: update PALETTE with redesigned 100-1200 shades
#1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Mar 13, 2024
|
|
||
| it('renders dark hue styling', () => { | ||
| /* eslint-disable-next-line jest/no-disabled-tests */ | ||
| it.skip('renders dark hue styling', () => { |
Member
Author
There was a problem hiding this comment.
These .skip tests will need to be restored in some form when custom hue styling is addressed in Chrome.
jzempel
commented
Mar 13, 2024
Comment on lines
+68
to
+69
| colors.background = getColorV8('neutralHue', 1100, DEFAULT_THEME); | ||
| colors.foreground = getColorV8('neutralHue', 300, DEFAULT_THEME); |
Member
Author
There was a problem hiding this comment.
these are based on dark mode defaults in Figma
jzempel
force-pushed
the
jzempel/palette
branch
from
4af9835 to
f76edab
Compare
geotrev
approved these changes
Mar 13, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets a new
PALETTEbaseline for Garden component redesign. Currently all component colors are washed out. But work will continue on thenext-colorbranch to re-apply color throughout with a newgetColorfunction.Detail
colors.foregroundupdated with new value (althoughcolors.foregroundandcolors.backgroundwill most likely be replaced by upcoming themevariables)