fix(theming)!: update utilities for refactored getColor
#1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Apr 10, 2024
| }} | ||
| argTypes={{ | ||
| position: { control: { type: 'radio', options: MENU_POSITIONS } } | ||
| position: { control: 'radio', options: MENU_POSITIONS }, |
There was a problem hiding this comment.
These select and radio controls were not working due to a previous Storybook update.
jzempel
commented
Apr 10, 2024
| if (typeof _hue === 'object') { | ||
| retVal = toHex(_hue, shade, offset, scheme); | ||
| } else if (valid(_hue)) { | ||
| } else if (_hue === 'transparent' || valid(_hue)) { |
There was a problem hiding this comment.
Restores parity with legacy getColorV8 and aligns with the CSS color spec.
geotrev
approved these changes
Apr 10, 2024
jzempel
changed the title
getColorgetColor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main consumer-facing change is the replacement
colorandspacerColorparameters on thegetFocusBoxShadowandfocusStylesutilities. All other PR updates are internal and include:focusStylesandgetFocusBoxShadow(note these are meant to have parity in this PR – redesigned light/dark color treatment will happen later)themingpackage references to deprecatedgetColorV8andPALETTE_V8typeparametersDetail
Temporary inspection of the object parameter
...argsallows the functions to straddle between v8 and v9 usage. No changes will be necessary on themainv8 codebase. SeegetFocusBoxShadow.tsfor details.Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge