feat(chrome)!: removes Subnav component #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
requested changes
Apr 12, 2024
Member
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
After you GH auth with CircleCI, we should be seeing an auto deployment on the PR 😉
| isFluid: { control: 'boolean' }, | ||
| skipNav: { name: 'children', table: { category: 'SkipNav' } }, | ||
| isExpanded: { name: 'Nav isExpanded', table: { category: 'Story' } }, | ||
| isWrapped: { name: 'Nav/SubNav isWrapped', table: { category: 'Story' } }, |
Member
There was a problem hiding this comment.
I think we still want the isWrapped control for Nav.
| hasFooter: boolean; | ||
| footerItems: IFooterItem[]; | ||
| isExpanded: boolean; | ||
| isWrapped: boolean; |
| }} | ||
| > | ||
| <Nav.ItemIcon>{NAV_ICONS[index] || <NavIcon />}</Nav.ItemIcon> | ||
| <Nav.ItemText isWrapped={isWrapped}>{item.text}</Nav.ItemText> |
jzempel
requested changes
Apr 12, 2024
Member
There was a problem hiding this comment.
[nit] should be isWrapped: { name: 'Nav isWrapped', table: { category: 'Story' } }, rather than 'Nav/Subnav isWrapped'.
Contributor
Author
There was a problem hiding this comment.
geotrev
approved these changes
Apr 12, 2024
Contributor
geotrev
left a comment
geotrev
left a comment
There was a problem hiding this comment.
Other than JZ's comment, looks good in code & demo.
jzempel
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Subnavcomponent and associated dependencies.Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)💂♂️ includes new unit tests. Maintain existing coverage (always >= 96%)♿ tested for WCAG 2.1 AA accessibility compliance