feat: adds StyledBaseIcon to various icon components #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
force-pushed
the
george/styled-icon-refactor
branch
from
6a68c25 to
fc5ef83
Compare
geotrev
force-pushed
the
george/styled-icon-refactor
branch
from
ec53455 to
765f345
Compare
geotrev
commented
Apr 18, 2024
| error: <ErrorIcon />, | ||
| warning: <WarningIcon />, | ||
| info: <InfoIcon /> | ||
| }[type]; |
There was a problem hiding this comment.
Not critical to this PR but I can't say no to DRY opportunities.
geotrev
changed the title
jzempel
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1791, updates various components with new
StyledBaseIcon.Detail
Key changes to note:
React.cloneElement(...)instances by extendingStyledBaseIconPackage/component checklist
react-buttonsStyledIconreact-formsStyledFileIconStyledTextMediaFigurereact-dropdownsStyledInputIconStyledOptionIconStyledOptionTypeIconreact-typographyStyledIconreact-notificationsStyledIconStyledGlobalAlertIconreact-paginationStyledIconreact-tagsStyledAvatarTesting considerations:
IconButtoninstances (used my multiple packages)Button.StartIconandButton.EndIconinstances (used by multiple packages)Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)?bedrock)