Skip to content

chore(next): updates from main #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024
Merged

chore(next): updates from main #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dfb7de
fix(Notifications): improve screen-reader support (#1790)
ze-flo Apr 18, 2024
6e31dab
chore(changelog): add v8.76.1
jzempel Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelogs/v8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@

_Note: Gaps between patch versions are faulty, broken or test releases._

## v8.76.1 (2024-04-18)

#### :bug: Bug Fix
* `notifications`
* [#1790](https://github.com/zendeskgarden/react-components/pull/1790) fix(Notifications): improve screen-reader support ([@ze-flo](https://github.com/ze-flo))

## v8.76.0 (2024-04-12)

#### :rocket: New Feature
Expand Down
7 changes: 4 additions & 3 deletions packages/notifications/src/elements/Notification.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ describe('Notification', () => {
it('has a default role attribute', () => {
const { container } = render(<Notification type="success" />);

expect(container.firstChild).toHaveAttribute('role', 'status');
expect(container.firstChild).toHaveAttribute('role', 'alert');
});

it('can have its role attribute modified', () => {
const { container } = render(<Notification type="error" role="alert" />);
// eslint-disable-next-line jsx-a11y/prefer-tag-over-role
const { container } = render(<Notification type="error" role="status" />);

expect(container.firstChild).toHaveAttribute('role', 'alert');
expect(container.firstChild).toHaveAttribute('role', 'status');
});

it('can have its role attribute removed', () => {
Expand Down
18 changes: 6 additions & 12 deletions packages/notifications/src/elements/Notification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,19 @@ import { Paragraph } from './content/Paragraph';
import { Close } from './content/Close';

export const NotificationComponent = forwardRef<HTMLDivElement, INotificationProps>(
({ role, ...props }, ref) => {
const Icon = props.type ? validationIcons[props.type] : InfoStrokeIcon;
const hue = props.type && validationHues[props.type];
({ children, type, ...props }, ref) => {
const Icon = type ? validationIcons[type] : InfoStrokeIcon;
const hue = type && validationHues[type];

return (
<StyledNotification
ref={ref}
type={props.type}
isFloating
{...props}
role={role === undefined ? 'status' : role}
>
{props.type && (
<StyledNotification ref={ref} type={type} isFloating role="alert" {...props}>
{type && (
<StyledIcon $hue={hue}>
<Icon />
</StyledIcon>
)}

{props.children}
{children}
</StyledNotification>
);
}
Expand Down