Skip to content

chore(next): update from main@8.76.2 #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2024
Merged

chore(next): update from main@8.76.2 #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
176582f
fix(forms): updates Message to receive margin when intermediaries are…
geotrev May 1, 2024
636beb0
chore(deps-dev): bump ejs from 3.1.9 to 3.1.10 (#1800)
dependabot[bot] May 2, 2024
54ed371
chore(changelog): add v8.76.2 [skip ci]
ze-flo May 2, 2024
04afe0e
fix(DatePickerStory): correct typo
ze-flo May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
293 changes: 162 additions & 131 deletions CHANGELOG.md
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions docs/changelogs/v8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@

_Note: Gaps between patch versions are faulty, broken or test releases._

## v8.76.2 (2024-05-02)

#### :bug: Bug Fix
* `datepickers`, `forms`
* [#1799](https://github.com/zendeskgarden/react-components/pull/1799) fix(forms): updates Message to receive margin when intermediaries are present ([@geotrev](https://github.com/geotrev))

#### :seedling: Internal
* [#1800](https://github.com/zendeskgarden/react-components/pull/1800) chore(deps-dev): bump ejs from 3.1.9 to 3.1.10 ([@dependabot[bot]](https://github.com/apps/dependabot))

## v8.76.1 (2024-04-18)

#### :bug: Bug Fix
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 17 additions & 1 deletion packages/datepickers/demo/datePicker.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ import README from '../README.md';
<Canvas>
<Story
name="DatePicker"
args={{ dateStyle: DATE_STYLE_OPTIONS[1], isAnimated: true }}
args={{
dateStyle: DATE_STYLE_OPTIONS[1],
eventsEnabled: true,
isAnimated: true,
message: 'Message'
}}
argTypes={{
value: { control: 'date' },
minValue: { control: 'date' },
Expand All @@ -25,6 +30,17 @@ import README from '../README.md';
control: 'radio',
options: DATE_STYLE_OPTIONS,
table: { category: 'Story' }
},
hasMessage: { name: 'Message', control: { type: 'boolean' }, table: 'Story' },
message: { name: 'children', control: { type: 'text' }, table: { category: 'Message' } },
validation: {
options: ['success', 'warning', 'error'],
control: { type: 'radio' },
table: { category: 'Input' }
},
validationLabel: {
control: { type: 'text' },
table: { category: 'Message' }
}
}}
parameters={{
Expand Down
27 changes: 22 additions & 5 deletions packages/datepickers/demo/stories/DatePickerStory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,45 @@

import React from 'react';
import { Story } from '@storybook/react';
import { Field, Input } from '@zendeskgarden/react-forms';
import { Grid } from '@zendeskgarden/react-grid';
import { Field, Input } from '@zendeskgarden/react-forms';
import { DatePicker, IDatePickerProps } from '@zendeskgarden/react-datepickers';
import { DATE_STYLE } from './types';

interface IArgs extends IDatePickerProps {
dateStyle: DATE_STYLE;
hasMessage?: boolean;
message?: string;
validation?: 'success' | 'warning' | 'error';
validationLabel?: string;
}

export const DatePickerStory: Story<IArgs> = ({ dateStyle, isCompact, ...args }) => {
export const DatePickerStory: Story<IArgs> = ({
dateStyle,
isCompact,
hasMessage,
message,
validation,
validationLabel,
...args
}) => {
const formatDate = (date: Date) =>
new Intl.DateTimeFormat(args.locale, { dateStyle }).format(date);

return (
<Grid>
<Grid.Row style={{ height: 'calc(100vh - 80px)' }}>
<Grid.Col textAlign="center" alignSelf="center">
<Grid.Row justifyContent="center" style={{ height: 'calc(100vh - 80px)' }}>
<Grid.Col alignSelf="center">
<Field>
<Field.Label hidden>{DatePicker.displayName}</Field.Label>
<DatePicker {...args} formatDate={formatDate} isCompact={isCompact}>
<Input isCompact={isCompact} style={{ width: isCompact ? 256 : 320 }} />
<Input isCompact={isCompact} validation={validation} />
</DatePicker>
{hasMessage && (
<Field.Message validation={validation} validationLabel={validationLabel}>
{message}
</Field.Message>
)}
</Field>
</Grid.Col>
</Grid.Row>
Expand Down
2 changes: 1 addition & 1 deletion packages/forms/src/styled/text/StyledTextInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ const sizeStyles = (props: IStyledTextInputProps & ThemeProps<DefaultTheme>) =>
${StyledHint} + &&,
${StyledMessage} + &&,
&& + ${StyledHint},
&& + ${StyledMessage} {
&& ~ ${StyledMessage} {
margin-top: ${props.theme.space.base * (props.isCompact ? 1 : 2)}px;
}
/* stylelint-enable */
Expand Down