feat(dropdowns): new light/dark mode colors #1816
Conversation
Use the
I would align add and danger here. Original reasoning was to make
For both Add and Danger, it's the same approach.
The rest looks great. 🙌 |
|
thanks @lucijanblagonic .. the PR has been updated with the finalized color design decisions. |
| const colorStyles = (props: IStyledValueProps) => { | ||
| const foregroundColor = props.isPlaceholder && getColorV8('neutralHue', 400, props.theme); | ||
| const colorStyles = ({ theme, isPlaceholder }: IStyledValueProps) => { | ||
| const foregroundColor = isPlaceholder && getColor({ theme, variable: 'foreground.disabled' }); |
There was a problem hiding this comment.
Should this return undefined or does styled-components evaluate properties as falsey to omit them? I see both around the codebase so just confirming.
There was a problem hiding this comment.
styled-components does the right thing
Description
Verified
Comboboxwith all combinations of:startIcon&endIcon,placeholder,inputValue,focusInset,validation,isMultiselectablewith tags & more thanmaxTags, andisDisabled.Verified
Optionwith all combinations of:icon,isSelected,type,isDisabled, andOption.Meta.Verified
OptGroupwithlabel&icon.Ensured that all
Optioncombinations were inherited as expected byMenu>Item.Detail
There are two outstanding questions for design re:
<Option type="add"><Option isDisabled>Checklist
npm start)renders as expected with reversed (RTL) direction?bedrock)tested for WCAG 2.1 AA accessibility compliance