- 
                Notifications
    
You must be signed in to change notification settings  - Fork 97
 
          feat(modals): new light/dark mode colors for TooltipModal and Drawer
          #1840
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'data-garden-id': COMPONENT_ID, | ||
| 'data-garden-version': PACKAGE_VERSION | ||
| 'data-garden-version': PACKAGE_VERSION, | ||
| size: 'small' | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] the general Garden preference is to locate these props on the element component – where they provide somewhat better prominence. Styled components that show otherwise are anti-patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that what you expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great!
Just one thing: the story for TooltipModal is using getColorV8 which makes the trigger text dim in dark mode:
foreground.default oughta do it?
          
 Good call out. 💯  This is related to what @jzempel described during our Design sync. I'll explicitly define the   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🙌

Description
Part 2 of the Modals recoloring effort.
Detail
TooltipModalandDrawerChecklist
npm start)🤘 renders as expected with Bedrock CSS (?bedrock)