fix(chrome,loaders): ferry props to view component transient props #2007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the
styled-componentstransient naming work, a few props got missed. This PR ensures the following are properly ferried to the underlying view components:<Header.ItemWrapper isRound={...} maxX={...} maxY={...}><Dots size={...}><Spinner size={...}>Detail
Also cleans up Storybook
VARIABLEScontext args that were leaking into rendered styled components.Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with reversed (RTL) directionrenders as expected in dark moderenders as expected with Bedrock CSS (?bedrock)includes new unit tests. Maintain existing coverage (always >= 96%)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge