Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Feb 3, 2025

Description

During the styled-components transient naming work, a few props got missed. This PR ensures the following are properly ferried to the underlying view components:

  • <Header.ItemWrapper isRound={...} maxX={...} maxY={...}>
  • <Dots size={...}>
  • <Spinner size={...}>

Detail

Also cleans up Storybook VARIABLES context args that were leaking into rendered styled components.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel merged commit 61795c9 into main Feb 5, 2025
9 checks passed
@jzempel jzempel deleted the jzempel/fix-transient branch February 5, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants