Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 9, 2025

Description

The original GlobalAlert was designed to support stacking by defining a bottom border. The implementation used box-shadow to avoid affecting size. However, without inset the "border" was cut off. This PR fixes GlobalAlert to honor the original design intent.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

Coverage Status

coverage: 95.511%. remained the same
when pulling 1cee41c on jzempel/global-alert-shadow
into 99e953d on main.

@jzempel jzempel merged commit af9e786 into main Jul 10, 2025
9 checks passed
@jzempel jzempel deleted the jzempel/global-alert-shadow branch July 10, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants