fix(dropdowns): ensure Menu closes on outside click when nested item is auto-focused #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
requested changes
Jul 31, 2025
packages/dropdowns/package.json
Outdated
| "@floating-ui/react-dom": "^2.0.0", | ||
| "@zendeskgarden/container-combobox": "^2.0.5", | ||
| "@zendeskgarden/container-menu": "^1.0.0", | ||
| "@zendeskgarden/container-menu": "1.0.1", |
There was a problem hiding this comment.
Suggested change
| "@zendeskgarden/container-menu": "1.0.1", | |
| "@zendeskgarden/container-menu": "^1.0.1", |
As a rule, Garden container dependencies get hat notation.
There was a problem hiding this comment.
Sorry, old habits. 🤦
jzempel
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
This PR is a follow-up to zendeskgarden/react-containers#699 and resolves an issue where clicking outside a menu dropdown does not close it when a nested item is auto-focused.
Detail
Before
Screen.Recording.2025-07-31.at.9.42.26.AM.mov
After
Screen.Recording.2025-07-31.at.9.45.32.AM.mov
Checklist
[ ] 👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)[ ] ⚫ renders as expected in dark mode[ ] 🤘 renders as expected with Bedrock CSS (?bedrock)[ ] 💂♂️ includes new unit tests. Maintain existing coverage (always >= 96%)