Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Aug 15, 2025

Description

This gets warnings out of the dev console for:

  • rendered Avatar components that are legitimately hidden
  • Modal.Close components that are described by a a tooltip
  • leaked styled toast notification placement prop

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel changed the title fix(avatars): prevent status label for aria-hidden Avatar fix(avatars,modals): prevent useText warnings for aria-hidden Avatar and aria-describedby Modal close Aug 18, 2025
@jzempel jzempel changed the title fix(avatars,modals): prevent useText warnings for aria-hidden Avatar and aria-describedby Modal close fix(avatars,modals): prevent dev console warnings Aug 18, 2025
@jzempel jzempel changed the title fix(avatars,modals): prevent dev console warnings fix(avatars,modals,notifications): prevent dev console warnings Aug 18, 2025
@jzempel jzempel merged commit 6b6c5e7 into main Aug 18, 2025
8 checks passed
@jzempel jzempel deleted the jzempel/hidden-avatar branch August 18, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants