-
Notifications
You must be signed in to change notification settings - Fork 97
BREAKING CHANGE: upgrade to React@v16.8 and styled-components@v4 #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I think you should do the testing deletion as a separate PR so as not to bury it here, we should also publish a deprecation notice to the package so anyone installing can see that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant work here, @Austin94. I just have a few clean-up items:
- Remove the invalid "Installation" and "Requirements" for:
dropdowns/README.mdforms/README.md
- Replace
Fragmentwith<>usage onpackages/buttons/README.md(also</Fragement>is misspelled) - Fix “install peer dependencies” on root
README.md - It probably makes sense to drop the
tagprop from typography components, now that we haveasviastyled-components. - Please consider if it makes sense to complete the "deprecate packages replaced by
react-forms" task before this PR is merged.
Thanks!
This doesn't include a version anywhere. What needs fixing?
I'm mixed about this. The
Let's do that as a follow on. Would be a great excuse to give the new versioning, release, and changelog management flow a test. |
|
@Austin94 the list is missing peer dependencies required for |
3277090 to
8fb1318
Compare
Description
Here is the final React 16.8 and styled-components v4.2 upgrade PR! This will eventually be paired with our upcoming versioning changes.
This is a BREAKING CHANGE which requires peerDependency changes, styled-components deprecation removals, and
innerRefremoval due to theReact.forwardRefAPI.Detail
This PR is split into several commits to allow for easy review. All changes have gone through an initial review when being merged into this branch, but you can review each package upgrade by its commit.
Checklist
designer as a reviewer)
component
yarn start)