Skip to content

fix(avatars): update avatar CSS for badge animation #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2019
Merged

fix(avatars): update avatar CSS for badge animation #363

merged 3 commits into from
Jun 14, 2019

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jun 13, 2019 •
edited
Loading

  • BREAKING CHANGE?

Description

Use @zendeskgarden/css-avatars v6.0.0.

Before

Kapture 2019-06-13 at 8 54 26

After

Kapture 2019-06-13 at 8 55 55

Notice, with the removal of the <figcaption> element, all badge transitions now scale in/out as desired.

Detail

Described under zendeskgarden/css-components#202

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team June 13, 2019 15:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 94.733% when pulling 31fb3f3 on jzempel/avatar-animation into e01d844 on master.

@jzempel jzempel merged commit 92110f1 into master Jun 14, 2019
@jzempel jzempel deleted the jzempel/avatar-animation branch June 14, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryanseddon ryanseddon ryanseddon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jzempel @coveralls @ryanseddon