fix(buttons): Pass className to <Icon /> #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
approved these changes
Jun 14, 2019
jzempel
changed the title
austingreendev
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Approved with the jest matcher updates.
@jzempel with the products still consuming pre-v6 Garden, will this be the first back port candidate?
giacomorebonato
force-pushed
the
grebonato/pass_classname_to_icon
branch
from
f9645a7 to
d476bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, this is my first Garden PR. Happy to learn and to adjust anything :)
Passes down the className prop to the component, for using it with styled components, fela and other CSS in JS libraries.
Detail
#365
Checklist