fix(notifications): show correct Notification and Alert styling #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like the
.attrs()logic in styled-components has changed again styled-components/styled-components#2372This was working after our 4.2.0 upgrade, but now certain props aren't being passed to their composed elements.
This is working in other packages as we only add to the
classNameattribute.Detail
To resolve this issue I removed all usages of
styled(Well)and am now applying the required styles directly.Checklist
designer as a reviewer)
component
yarn start)