Skip to content

fix(dropdowns): remove webkit button styling when used with css-bedrock #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

fix(dropdowns): remove webkit button styling when used with css-bedrock #386

merged 1 commit into from
Jul 11, 2019

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Jul 11, 2019 •
edited
Loading

Description

When products use normalize.css, specifically https://github.com/necolas/normalize.css/blob/master/normalize.css#L195-L200, and @zendeskgarden/css-bedrock it is possible to have some styling conflicts with the Select and Autocomplete components in react-dropdowns.

Detail

This PR introduces an appearance rule with higher specificity.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team July 11, 2019 22:28
carvallegro
carvallegro approved these changes Jul 11, 2019
View reviewed changes
Copy link

@carvallegro carvallegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.428% when pulling 3162cbb on agreen/dropdowns-button into a09a170 on master.

@austingreendev austingreendev merged commit 8d9bd7c into master Jul 11, 2019
@austingreendev austingreendev deleted the agreen/dropdowns-button branch July 11, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

+1 more reviewer

@carvallegro carvallegro carvallegro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@austingreendev @coveralls @jzempel @carvallegro