Skip to content

feat(breadcrumbs): deprecate BreadcrumbContainer and migrate to useBreadcrumb() container #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2019
Merged

feat(breadcrumbs): deprecate BreadcrumbContainer and migrate to useBreadcrumb() container #444

merged 2 commits into from
Sep 9, 2019

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Sep 6, 2019 •
edited
Loading

Description

This PR deprecates the BreadcrumbContainer component within react-breadcrumbs and migrates the packages to the useBreadcrumb() container.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team September 6, 2019 21:59
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.806% when pulling 55cb416 on agreen/breadcrumb-deprecation into 3b44001 on master.

@austingreendev austingreendev merged commit 6709d7f into master Sep 9, 2019
@austingreendev austingreendev deleted the agreen/breadcrumb-deprecation branch September 9, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

Assignees

No one assigned

Labels

PR: New Feature 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austingreendev @coveralls @jzempel