Skip to content

Conversation

@ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Sep 13, 2024

FOR DEMO PURPOSES ONLY - DO NOT MERGE ❗

Description

Adds a "Controlled + Managed Focus" Story to demo the restoreFocus behavior featured in #659 with a controlled menu.

@coveralls
Copy link

Coverage Status

coverage: 95.714% (-0.002%) from 95.716%
when pulling f43e450 on ze-flo/menu-restore-focus
into ec77a9d on main.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like moving this to a "Controlled trigger focus" story (using all of the standard code constructs) under the "[patterns]" section would be a valuable addition to #659 so we can easily track the behavior going forward. Compare with many of the other "[pattern]" stories – many/all of the arg controls can be removed.

@ze-flo
Copy link
Contributor Author

ze-flo commented Sep 25, 2024

Feels like moving this to a "Controlled trigger focus" story (using all of the standard code constructs) under the "[patterns]" section would be a valuable addition to #659 so we can easily track the behavior going forward. Compare with many of the other "[pattern]" stories – many/all of the arg controls can be removed.

In the interest of time and to unblock #659, is it okay to add the new [patterns] story in a follow-PR?

@jzempel
Copy link
Member

jzempel commented Sep 25, 2024

Feels like moving this to a "Controlled trigger focus" story (using all of the standard code constructs) under the "[patterns]" section would be a valuable addition to #659 so we can easily track the behavior going forward. Compare with many of the other "[pattern]" stories – many/all of the arg controls can be removed.

In the interest of time and to unblock #659, is it okay to add the new [patterns] story in a follow-PR?

Definitely works for me.

@ze-flo
Copy link
Contributor Author

ze-flo commented Oct 14, 2024

The restoreFocus story will be added under the Menu's [pattern] section. Closing PR but keeping branch.

@ze-flo ze-flo closed this Oct 14, 2024
@ze-flo ze-flo deleted the ze-flo/menu-restore-focus branch May 12, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants