Skip to content

fix(menu): prevent click propagation to container components #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

fix(menu): prevent click propagation to container components #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/menu/src/MenuContainer.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,23 @@ describe('MenuContainer', () => {
expect(menu).not.toBeVisible();
});

it('prevents menu click propagation', async () => {
const handleClick = jest.fn();
const { getByTestId } = render(
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
<div onClick={handleClick}>
<TestMenu items={ITEMS} />
</div>
);
const menu = getByTestId('menu');

await act(async () => {
await user.click(menu);
});

expect(handleClick).not.toHaveBeenCalled();
});

it('closes the menu on blur due to a body click, returns focus to the trigger the first time, and focuses the body on following clicks.', async () => {
const { getByTestId } = render(<TestMenu items={ITEMS} />);
const trigger = getByTestId('trigger');
Expand Down
12 changes: 9 additions & 3 deletions packages/menu/src/useMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ export const useMenu = <T extends HTMLElement = HTMLElement, M extends HTMLEleme
]
);

const handleMenuClick = useCallback((event: React.MouseEvent) => {
// Prevent propagation to container; for example, accordion header expand/collapse
event.stopPropagation();
}, []);

const handleMenuKeyDown = useCallback(
(event: KeyboardEvent) => {
const { key } = event;
Expand Down Expand Up @@ -776,7 +781,7 @@ export const useMenu = <T extends HTMLElement = HTMLElement, M extends HTMLEleme
);

const getMenuProps = useCallback<IUseMenuReturnValue['getMenuProps']>(
({ role = 'menu', onBlur, onMouseLeave, ...other } = {}) => ({
({ role = 'menu', onBlur, onClick, onMouseLeave, ...other } = {}) => ({
...other,
...getGroupProps({
onMouseLeave: composeEventHandlers(onMouseLeave, handleMenuMouseLeave)
Expand All @@ -787,9 +792,10 @@ export const useMenu = <T extends HTMLElement = HTMLElement, M extends HTMLEleme
tabIndex: -1,
role: role === null ? undefined : role,
ref: menuRef as any,
onBlur: composeEventHandlers(onBlur, handleBlur)
onBlur: composeEventHandlers(onBlur, handleBlur),
onClick: composeEventHandlers(onClick, handleMenuClick)
}),
[getGroupProps, handleBlur, handleMenuMouseLeave, menuRef, triggerId]
[getGroupProps, handleBlur, handleMenuClick, handleMenuMouseLeave, menuRef, triggerId]
);

const getSeparatorProps = useCallback<IUseMenuReturnValue['getSeparatorProps']>(
Expand Down