Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use moon/sun icons for code example dark/light mode toggle #646

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Sep 19, 2024

Description

Upgrades to the latest svg-icons 7.3.0 in order to use new moon (sun) icons. The code example toggle button is updated.
Kapture 2024-09-19 at 17 47 35

Note that the logic is in place for handling the website in dark mode (functionality not available in this branch).
Kapture 2024-09-19 at 17 44 32

Detail

This PR also shims in:

  • a fix for a Pane example that was not rendering the proper height
  • upgrade to the latest react-components v9.0.0-next.26

Checklist

  • 👌 website updates are Garden Designer approved (add the designer as a reviewer)
  • ✒️ copy updates are approved (add the content strategist as a reviewer)
  • 🔗 considered opportunities for adding cross-reference URLs (grep for keywords)
  • analyzed via axe and evaluated using VoiceOver
  • 📝 tested in Chrome, Firefox, Safari, Edge

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be more straightforward and predictable to use sun-fill.svg and moon-fill.svg consistently, regardless of the website's mode. Should we follow up with the design team to confirm?

@jzempel jzempel merged commit 1f07a02 into next Sep 23, 2024
3 checks passed
@jzempel jzempel deleted the jzempel/sun-moon-icons branch September 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants