Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

add composer.lock & update travis config #101

Closed

Conversation

stefanotorresi
Copy link
Contributor

@stefanotorresi stefanotorresi commented May 26, 2016

as per zendframework/zendframework#7660

also entails these changes:

@thomasvargiu
Copy link
Contributor

@stefanotorresi You should disable APC and memcache with PHP 7.
Can you update your travis settings?

@marc-mabe
Copy link
Member

@thomasvargui In my opinion this travis error has nothing to do with this PR.

It's related to https://pear.php.net/bugs/bug.php?id=21007 and found the way into the repo by #82, #74 and #52.

The problem now is that a test for a race condition is using different PHP processes and installing apc_bc on PHP 7 requires an extension load order where it fails installed by pecl. On travis there is a hack that adds the extension two times. That worked but PHP triggers a warning on startup but the warning gets be detected now because PHPUnit needs to run this race condition test in an own process.

If we fix the extension install / loading completely this issue should be gone

@stefanotorresi
Copy link
Contributor Author

stefanotorresi commented May 27, 2016

@thomasvargiu @marc-mabe

fixed by installing apcu_bc manually rather than via PECL

also unsupported php 7 extentions mongo and memcache are now correctly disabled

@stefanotorresi stefanotorresi force-pushed the composer-lock branch 2 times, most recently from bda31fe to c93ed95 Compare May 27, 2016 11:52
@stefanotorresi
Copy link
Contributor Author

@marc-mabe ping, I see from IRC that you're working on the same changes I'm doing atm :D let me handle this!

@marc-mabe
Copy link
Member

@stefanotorresi ok I'll wait - You can check my changes here https://github.com/marc-mabe/zend-cache/tree/travis_apc_php7 the only issue I have is that in PHP-7 apc.so doesn't get loaded this way I think because I add it to .ci/apcu.so after this file was added

@stefanotorresi stefanotorresi force-pushed the composer-lock branch 5 times, most recently from 12773b5 to beb50e9 Compare May 27, 2016 15:36
@stefanotorresi
Copy link
Contributor Author

@marc-mabe should be good now!

add env variable for apcu version

fix apc and xcache loading

remove redundant env variables

fix apc extension loading

make phpunit verbose

fix secure env variable

minor finishing touches
@marc-mabe
Copy link
Member

@stefanotorresi Looks much better now 👍

But I still have two questions:

  • why did you increase the minimum required PHP version? Did I missed something?
  • Why do you load apc_bc manuelly instead of using pecl + removing the 'extension=' part from php.ini as in loading apc.so?

@weierophinney
Copy link
Member

why did you increase the minimum required PHP version? Did I missed something?

We haven't announced it, but I've talked about it on IRC. Next minor/major versions of all components will be bumped to 5.6, as 5.5 goes EOL next month. @stefanotorresi is making that change along with the composer.lock additions.

@marc-mabe marc-mabe self-assigned this May 30, 2016
@marc-mabe marc-mabe added this to the 2.8.0 milestone May 30, 2016
@marc-mabe
Copy link
Member

@weierophinney Thanks for the info!
I added the BC Break label because of that but I'll also backport the changes to master without the PHP version upgrade as this actually contains a fix for running the tests in travis.

@stefanotorresi I did some additional changes:

  • Install lowest, locked and latest versions of apcu(_bc). If we already need to install the extensions we can also install different versions for different runs ;)
    • replace INSTALL_APCU_BC with APCU_BC_PECL_VERSION
  • use the variables APCU[_BC]_PECL_VERSION as marker for install and loading ini file conditions
  • removed composer self-update as this will be done by travis already
  • run composer test scripts as composer run-script test[-coverage] --timeout=XXXX because I run into a timout issue introduced by composer see https://travis-ci.org/marc-mabe/zend-cache/jobs/133889679#L896

You can take a look into the changes here https://github.com/marc-mabe/zend-cache/blob/hotfix/101/.travis.yml
If you don't have any objections I'll merge it tomorrow

@stefanotorresi
Copy link
Contributor Author

LGTM :)

@marc-mabe
Copy link
Member

closed by 1a76834 (develop) and d93aaa2 (master)

@marc-mabe marc-mabe closed this May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants