This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Implements an adapter for ext-mongodb #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
force-pushed
the
feature/ext-mongodb-support
branch
from
28a9fb7 to
938b158
Compare
weierophinney
force-pushed
the
feature/ext-mongodb-support
branch
2 times, most recently
from
33a0973 to
94b6b17
Compare
This patch is an alternative to zendframework#132, proposing a parallel adapter for ext-mongodb, instead of repurposing the existing ext-mongo adapter to only work with ext-mongodb. It copies the various `MongoDb*` classes to `ExtMongoDb*` variants, and applies the changes as suggested in zendframework#132. Additionally, it sets up the test harness to test ext-mongodb support in PHP 7.1 and 7.2, while testing ext-mongo support in PHP 5.6 and 7.0. When it tests ext-mongodb, it also adds a dependency on mongodb/mongodb so that the client library is available.
weierophinney
force-pushed
the
feature/ext-mongodb-support
branch
from
94b6b17 to
cc7cec2
Compare
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an alternative to #132, proposing a parallel adapter for ext-mongodb, instead of repurposing the existing ext-mongo adapter to only work with ext-mongodb.
It copies the various
MongoDb*classes toExtMongoDb*variants, and applies the changes as suggested in #132. Additionally, it sets up the test harness to test ext-mongodb support in PHP 7.1 and 7.2, while testing ext-mongo support in PHP 5.6 and 7.0. When it tests ext-mongodb, it also adds a dependency on mongodb/mongodb so that the client library is available.