This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove zend-version dev dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Closed
| require_once $filePath; | ||
| $reflectionFile = new FileReflection($filePath); | ||
| $this->assertEquals(get_class($reflectionFile), 'Zend\Code\Reflection\FileReflection'); | ||
| } |
There was a problem hiding this comment.
I'd argue we still need the test, but should use a different class for it, perhaps just another class in the component.
There was a problem hiding this comment.
I've found many zend-code tests do this kind of assertions about if the constructor don't throw any exception.
However rests of tests do the same but specific to the intended behavior. So I did remove this because its covered by the rest of tests.
There was a problem hiding this comment.
yeah. Testing that new ... gives you an object of this class is either testing PHP (useless) or testing that there is no exception when passing a file (already covered by other tests as they would break)
weierophinney
added a commit
that referenced
this pull request
Nov 18, 2015
Remove zend-version dev dependency
weierophinney
added a commit
that referenced
this pull request
Nov 18, 2015
weierophinney
added a commit
that referenced
this pull request
Nov 18, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.