Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix exception message in ValueGenerator for invalid values #179

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix exception message in ValueGenerator for invalid values #179

merged 1 commit into from
Dec 10, 2019

Conversation

michalbundyra
Copy link
Member

When resource provided we should throw exception that this type
cannot be used, but we tried to get_class on resource, what is invalid.

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

Fixes #178

When resource provided we should throw exception that this type
cannot be used, but we tried to get_class on resource, what is invalid.
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 🚢

michalbundyra added a commit that referenced this pull request Dec 10, 2019
…alid-value

Fix exception message in ValueGenerator for invalid values
michalbundyra added a commit that referenced this pull request Dec 10, 2019
michalbundyra added a commit that referenced this pull request Dec 10, 2019
michalbundyra added a commit that referenced this pull request Dec 10, 2019
@michalbundyra michalbundyra merged commit 6a666cb into zendframework:master Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method Zend\Code\Generator\ValueGenerator::__toString() must not throw an exception (with PHP 7.3)
3 participants