This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix handling of FQCNs in method parameters #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, MethodScanner did not detect a leading T_NS_SEPARATOR character for a type name. By failing to detect it, it passes it to ParameterScanner without it, who then dutifully resolves the classname as if it was relative to the current namespace. This is obviously incorrect behaviour, and it is fixed with this patch. Tests have also been added and updated.
|
Looks like I messed up a couple of things when submitting the PR. Will close and re-submit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
MethodScannerdid not detect a leadingT_NS_SEPARATORcharacter for a type name. By failing to detect it, it passes it to
ParameterScannerwithout it, who then dutifully resolves the classnameas if it was relative to the current namespace.
This is obviously incorrect behaviour, and it is fixed with this patch.
Tests have also been added and updated.