Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

[v2] Strict types declaration placed before copyright block #15

Open
@Xerkus

Description

@Xerkus

With copyright docblock using older @link tag format, strict types declaration is placed before it.

 <?php
+
+declare(strict_types=1);
+
 /**
  * @link      http://github.com/zendframework/zend-mvc for the canonical source repository
  * @copyright Copyright (c) 2005-2018 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   https://github.com/zendframework/zend-mvc/blob/master/LICENSE.md New BSD License
  */

But with @see it is placed after the docblock as it should be:

 <?php
+
 /**
- * @link      http://github.com/zendframework/zend-mvc for the canonical source repository
+ * @see      http://github.com/zendframework/zend-mvc for the canonical source repository
  * @copyright Copyright (c) 2005-2018 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   https://github.com/zendframework/zend-mvc/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+

On a side note, should that extra empty line be added before copyright? Looks like unintended side effect of strict types sniff

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions