This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Complete #40: allow installation with packages defining multiple autoloader paths #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a switch nested under three levels of foreach loop, this extracts each loop operation to its own method. It accomplishes aggregation of dependencies by using `ArrayObject` internally to aggregate them.
This patch adds tests to cover zendframework#40. Specifically, it ensures that the installer will loop through all paths for each autoloader namespace entry, whether it's a single path or multiple paths, in order to determine if it has any module dependencies.
weierophinney
added a commit
that referenced
this pull request
Nov 6, 2017
Also removes empty 1.0.1 stub as it will not be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch completes #40, which fixes an issue when any given autoloader namespace is associated with multiple paths (versus a single path).
It does the following on top of #40:
loadModuleClassesDependencies()method to extract additional methods, one for each iteration. This simplifies each individual method dramatically.