This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Updated to zend-servicemanager v3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- composer.json entry for zend-servicemanager using `dev-develop as 2.7.0`. - Updated `AbstractConfigFactory` to follow new interface definition. - Updated `ReaderPluginManager` and `WriterPluginManager` to follow changes in `AbstractPluginManager`; they aggregate invokables and merge them with incoming configuration before passing on to the parent constructor. - Updated `Factory` to pass an empty service manager instance to plugin managers when lazy loading them.
|
👍 |
|
Coverage is less, as I marked a number of tests that feature the "Translator" processor as incomplete, until that component is updated for zend-servicemanager v3. |
| (is_object($plugin) ? get_class($plugin) : gettype($plugin)), | ||
| __NAMESPACE__ | ||
| )); | ||
| $config = array_merge_recursive(['invokables' => $this->invokableClasses], $config); |
There was a problem hiding this comment.
This approach is necessary as the SM doesn't have an $invokableClasses property any longer; it instead munges invokables into factory and alias definitions. As such, the configuration needs to be passed in during instantiation.
weierophinney
added a commit
to weierophinney/zend-modulemanager
that referenced
this pull request
Oct 2, 2015
- Pins to zend-servicemanager dev-develop as 2.7.0 - Pins to branch for zendframework/zend-config#8 as 2.6.0 - Removes the LocatorRegistered feature and related listener - DI integration was removed from zend-servicemanager already - ServiceListener overhaul: - Adds the `setApplicationServiceManager()` and `getServiceManagerConfig()` methods. The former is used to set the metadata for collecting application service manager configuration; the latter returns the merged configuration. These methods were added to both the interface and the implementation. - Aggregated plugins are instantiated, and added as "services" configuration for the service manager. When "pulled" from the service manager, the code uses `build()` to ensure the service is not cached, and to allow passing the configuration options. The plan is for zend-mvc's `Application::bootstrap()` to check for a service listener service on completion, and, if found, pull it. It will then pass the return value of `getServiceManagerConfig()` to the `withConfig()` method of it's own `ServiceManager`, re-assigning it to the return value. This will allow bootstrapping to provide a fully-configured service manager on completion, while still aggregating services required at initialization.
|
Missing the changelog file :) |
|
changelog added, @mwillbanks . :) |
mwillbanks
added a commit
that referenced
this pull request
Oct 2, 2015
Updated to zend-servicemanager v3
mwillbanks
added a commit
that referenced
this pull request
Oct 2, 2015
weierophinney
added a commit
that referenced
this pull request
Jan 21, 2016
- Merged it with the #8 changelog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-develop as 2.7.0.AbstractConfigFactoryto follow new interface definition.ReaderPluginManagerandWriterPluginManagerto follow changes inAbstractPluginManager; they aggregate invokables and merge them with incoming configuration before passing on to the parent constructor.Factoryto pass an empty service manager instance to plugin managers when lazy loading them.